Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transport): Return connection error on Channel::connect #413

Merged
merged 1 commit into from
Jul 27, 2020

Commits on Jul 27, 2020

  1. fix(transport): Return connection error on Channel::connect

    Before this fix, if the connect phase of the transport failed before
    ever establishing a connection, we would never return the error until
    the first call to send a request. This PR changes that behavior to only
    forward the error to the call method if we have ever made a connection
    before. If we have never established a connection before then
    `Reconnect` will return an error on the call to `poll_ready`.
    
    Fixes #403
    LucioFranco committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    1909775 View commit details
    Browse the repository at this point in the history