Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metadata): remove manual Send + Sync impls for metadata types #640

Merged
merged 1 commit into from
May 12, 2021

Commits on May 12, 2021

  1. feat(metadata): remove manual Send + Sync impls for metadata types

    Removes manual `Send` and `Sync` impls for these types as they weren't
    necessary:
    
    - `metadata::Iter`
    - `metadata::IterMut`
    - `metadata::ValueDrain`
    - `metadata::ValueIterMut`
    
    Since all the types they contained were `Send + Sync` we can rely on the
    compiler automatically adding the impls.
    
    Also added some tests to ensure we don't accidentally make them `!Send`
    or `!Sync` in the future.
    
    Fixes #636
    davidpdrsn committed May 12, 2021
    Configuration menu
    Copy the full SHA
    a1850f8 View commit details
    Browse the repository at this point in the history