Don't override fullscreen opacity if only two opacities are provided #5512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoSeDiK
force-pushed
the
fullscreen-opacity
branch
from
0850f28
to
9d69500
Compare
vaxerski
approved these changes
Apr 9, 2024
lisuke
pushed a commit
to lisuke/Hyprland
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Specifying single value in opacity window rule correctly sets it for all three states (active, inactive, fullscreen), but providing two values unintentionally sets fullscreen one too. This makes fullscreen opacity to be unset if two are specified (wiki's already written as if this is the case).
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Removed ...Override = falses since they are already false by default.Got confused by the fact the
alpha(active) didn't do this, unlike inactive/fullscreen, but this makes it impossible to reset theoverridelock.Added
m_sSpecialRenderData.alphaOverride = false;instead to allow resetting the active alpha's lock.Is it ready for merging, or does it need work?
Ready