Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session-lock: send locked after the lock screen is properly rendered #6850

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

MikeWalrus
Copy link
Contributor

The protocol says:

The locked event "must not be sent until a new "locked" frame (either from a
session lock surface or the compositor blanking the output) has been presented
on all outputs and no security sensitive normal/unlocked content is possibly
visible".

This helps users ensure the screen is properly locked before suspending the machine. (e.g. with swaylock --ready-fd)

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if a faulty lock doesnt lock all monitors?

src/managers/SessionLockManager.cpp Outdated Show resolved Hide resolved
@MikeWalrus
Copy link
Contributor Author

It'll show the fade-in red screen until it becomes opaque. Then it'll send the locked event.

what if a faulty lock doesnt lock all monitors?

@vaxerski
Copy link
Member

right, I see. Alright, just fix the style and this is gtg

The protocol says:
> The locked event "must not be sent until a new "locked" frame (either from a
> session lock surface or the compositor blanking the output) has been presented
> on all outputs and no security sensitive normal/unlocked content is possibly
> visible".

This helps users ensure the screen is properly locked before suspending
the machine. (e.g. with swaylock --ready-fd)
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vaxerski vaxerski merged commit 7486576 into hyprwm:main Jul 13, 2024
10 of 11 checks passed
@vaxerski vaxerski mentioned this pull request Jul 13, 2024
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants