Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NoSymbol keybinds #7199

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix NoSymbol keybinds #7199

merged 1 commit into from
Aug 7, 2024

Conversation

ikalco
Copy link
Contributor

@ikalco ikalco commented Aug 6, 2024

Describe your PR, what does it fix/add?

fixes #6721

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

this should still work for #6548
if you want we can @ the guy to test

Is it ready for merging, or does it need work?

yes

@vaxerski
Copy link
Member

vaxerski commented Aug 6, 2024

ye please @ em

@ikalco
Copy link
Contributor Author

ikalco commented Aug 6, 2024

@JaKooLit, sorry to ping but can you test this pr with plugging your charger to make sure this doesn't regress #6548

@JaKooLit
Copy link

JaKooLit commented Aug 6, 2024

@JaKooLit, sorry to ping but can you test this pr with plugging your charger to make sure this doesn't regress #6548

I will try once Im off work... I will let you know

Copy link

@JaKooLit JaKooLit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested. It does not affect this

#6548

@vaxerski vaxerski merged commit a05da63 into hyprwm:main Aug 7, 2024
10 checks passed
@ikalco ikalco deleted the fix_nosymbol_keybinds branch August 12, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key 248 and other NoSymbol keys not working
3 participants