xwayland: deactivate xwayland focus if wayland is focused

[Trimutex]

Describe your PR, what does it fix/add?

When going from XWayland -> Wayland the window doesn't actually unfocus until you activate another XWayland window. This removes the focus so the last XWayland window doesn't think its still focused.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Nope

Is it ready for merging, or does it need work?

Ready for merging

[Trimutex]

Should fix #7435

[koeqaife]

Should fix #7435

My discord works natively in wayland

[Trimutex]

Forgot to mention that this also fixes other things like going from some games on XWayland to a Wayland window causes chat input to stop working.

[Trimutex]

Should fix #7435

My discord works natively in wayland

Ah, thought it might have been what one comment was talking about, as it fixes that issue, apologies!
#7435 (comment)

[vaxerski]

this part has been a dangerous place.

I need prusa-slicer tested - notorious for not working with popups when something is off

[Trimutex]

this part has been a dangerous place.

I need prusa-slicer tested - notorious for not working with popups when something is off

Understandable that something like this would want to be tested a bunch. Been using it for the past day and I can only see minor fixes on my side. Any specific things you want me to run through to test?

[vaxerski]

see the second line of my message

[Trimutex]

Ah, I didn't realize prusa-slicer was a program name so I misunderstood.

Downloaded prusa-slicer 2.8.0-1 and attempted to get to default settings from my understanding. Menu's seem to function normally, but messing around with it too long causes Hyprland to crash, both on -git and using this commit.
Edit note: Hyprland crash is on subsequent launches of program after first prusa crash, prusa just refuses to open if Hyprland is not restarted. Error is invalid (NULL) pointer instance && g_signal_handlers_disconnect_matched: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed.

I can try to work on bisecting that crash as well but it seems unrelated to any issues with the commit itself.

[Trimutex]

Ignore above, issues with Wayland for prusa-slicer are already known. See prusa3d/PrusaSlicer#12246

Prusa-slicer behaves as normal with no bugs in popups and menus using solution found here: prusa3d/PrusaSlicer#12867

@vaxerski ping if you needed as testing went fine

[vaxerski]

can you ping me tomorrow evening, I'll do some testing

[izmyname]

@vaxerski I'm not the op, but anyway.

[vaxerski]

regresses #6616 with bambustudio

launch bambustudio

go to preview

click any dropdown, it instantly closes

the reason is that you send an unfocus event to bambu incorrectly

[Trimutex]

Hmm, ok I'll look into it and create a better fix then. Couldn't find those issues when I searched on GitHub :/

[vaxerski]

even I get lost in the tracker, don't worry

[Trimutex]

Should behave like normal now, and only remove focus if going from xwayland -> wayland.

Side note: Testing using bambustudio crashes Hyprland if I mess with it too much (like around 5 pop-up clicks). Getting this while testing with -git and these commits. Is this a known thing, just due to my hardware that I gotta figure out, or unknown?

[vaxerski]

I've never had that, can you get a debug stacktrace? https://wiki.hyprland.org/Crashes-and-Bugs/#obtaining-a-debug-stacktrace

[Trimutex]

Sure, I'm going to go ahead and open an issue for it though, since its off topic

[Trimutex]

Issue moved to #7506

[vaxerski]

thanks!