APP-677: Fix compilation errors for swift 5.2 #101
Conversation
niil-ohlin
force-pushed
the
fix-swift-5.2
branch
from
f758a36
to
4ded50e
Compare
niil-ohlin
force-pushed
the
fix-swift-5.2
branch
from
4ded50e
to
be6b409
Compare
| @@ -24,7 +24,7 @@ public final class CoreSignal<Kind: SignalKind, Value> { | |||
| public typealias Event = Flow.Event<Value> | |||
| typealias EventType = Flow.EventType<Value> | |||
|
|
|||
| internal init(onEventType: @escaping (@escaping (EventType) -> Void) -> Disposable, _ noTrailingClosure: Void = ()) { | |||
There was a problem hiding this comment.
This trick stopped working in swift 5.2
There was a problem hiding this comment.
What is the compiler complaining about?
There was a problem hiding this comment.
The new compiler now allows init(onEventType:) to be called with trailing closure syntax. So there was ambiguity between init(onEventType:) and init(onValue:)
niil-ohlin
changed the title
There was a problem hiding this comment.
I would be fine with merging this and making a point release. Any opinions @mansbernhardt?
| test-xcode10-ios12: | ||
| macos: | ||
| xcode: "10.3.0" | ||
| steps: | ||
| - test_main_project |
There was a problem hiding this comment.
think that this can be cleaned up as well.
| test-xcode11-4-beta-ios13: | ||
| macos: | ||
| xcode: "11.4.0" | ||
| steps: | ||
| - test_main_project |
There was a problem hiding this comment.
is there a reason for keeping the old runner and not making this the default runner?
|
@moglistree As it only seems to be internal fixes and I would assume it will still compile with Swift 5.1, then it feels safe to release as a point release. |
|
Yes I have testes swift 4.2, 5.0, 5.1 and its all good |
The
noTrailingClosuretrick stopped working for swift 5.2. Remove that and fix the ambiguity. The explicit requirement is only a problem internally in the framework. External code will still be able to use the trailing closure syntax.