Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump new major version of flow. #99

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bump new major version of flow. #99

wants to merge 3 commits into from

Conversation

niil-ohlin
Copy link
Contributor

No description provided.

@niil-ohlin niil-ohlin changed the title Bump podfile Bump new major version of flow. Sep 26, 2019
Copy link
Contributor

@nataliq nataliq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some description to the PR. Maybe the upgrade notes as we did for the Form major release: iZettle/Form#130
It's also a good idea to post in the oss slack that you're preparing 2.0 release, maybe there are more things to include?

@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "FlowFramework"
s.version = "1.8.3"
s.version = "2.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FlowTests plist should also be updated. Are you using agvtool?

@@ -1,6 +1,10 @@
# 2.0.0

- Remove custom Result type in favour of `Swift.Result`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there some code related to this to be removed in this PR? Some deprecations?

@moglistree moglistree requested a review from a team as a code owner February 14, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants