Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Issue with latest release 1.0.1 #5

Closed
tommarien opened this issue Nov 29, 2019 · 4 comments
Closed

Issue with latest release 1.0.1 #5

tommarien opened this issue Nov 29, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@tommarien
Copy link

Due to addition of resourceloader all tests now actually tries to load the resources, which we cannot seem to toggle off.

see https:/jsdom/jsdom#loading-subresources

Please advise

@ianschmitz
Copy link
Owner

Ah yes thank you for reporting @tommarien. That was an unintended consequence of trying to fix userAgent support in #4. I'll revert and push out a patch shortly.

@ianschmitz ianschmitz added the bug Something isn't working label Nov 29, 2019
@ianschmitz
Copy link
Owner

Reverted in 1.0.2. @diegohaz just a heads up that this reverted your change.

@tommarien
Copy link
Author

@ianschmitz Thanks ;)

@diegohaz
Copy link
Contributor

@ianschmitz Thanks for letting me know and taking care of this so fast! Posted an alternative solution for my problem here: #3 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants