New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup remaining process at exit #1

Merged

iberianpig merged 3 commits into main from cleanup-remaining-process-at-exit

Aug 19, 2023

Owner

iberianpig commented Aug 19, 2023 •

edited

Loading

Shutdown child process created by fork at input plugin startup

Override Plugin::Base#shutdown with including CustomProcess
Update gemspec to depend on fusuma 3(not released yet)

The background for this PR includes the following issues:

When there are residual processes at startup, it can lead to a failure in starting up.
- Some input plugins are believed to be the cause.
- A feature to kill child processes has been added to CustomProcess#shutdown when the main process ends.
After a kill operation, the original keyboard input remains grabbed.

iberianpig added 3 commits

August 19, 2023 15:36


fix(remapper): ignore error when ungrabbing keyboard

e99cc42


fix(input): cleanup remaining process at exit

4877d1a


feat(gemspec): update fusuma dependency

1c41b69

iberianpig marked this pull request as ready for review

August 19, 2023 10:00

iberianpig merged commit 76404f3 into main

6 checks passed

iberianpig deleted the cleanup-remaining-process-at-exit branch

September 6, 2023 12:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment