internal/gps: return an error instead of panicing

solver.selectRoot() panics when solver.intersectConstraintsWithImports() returns an error. This commit returns the error instead if that error is due to inability to deduce a project repository. Solves golang#292 and golang#581 Signed-off-by: Ibrahim AshShohail <[email protected]>
ibrasho-forks · Jun 6, 2017 · c72bb5b · c72bb5b
1 parent ce194b4
commit c72bb5b
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/internal/gps/solver.go b/internal/gps/solver.go
@@ -545,6 +545,9 @@ func (s *solver) selectRoot() error {
  // analysis, rather than having the sm do it
  deps, err := s.intersectConstraintsWithImports(s.rd.combineConstraints(), s.rd.externalImportList(s.stdLibFn))
  if err != nil {
+ if strings.HasPrefix(err.Error(), "unable to deduce repository and source type for:") {
+ return err
+ }
  // TODO(sdboyer) this could well happen; handle it with a more graceful error
  panic(fmt.Sprintf("shouldn't be possible %s", err))
  }