Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GetHashCode and Equals in terms of the type hierarchy #274

Open
rianjs opened this issue Apr 28, 2017 · 1 comment
Open

Implement GetHashCode and Equals in terms of the type hierarchy #274

rianjs opened this issue Apr 28, 2017 · 1 comment

Comments

@rianjs
Copy link
Collaborator

rianjs commented Apr 28, 2017

Extending some of the ideas from #271, calendar components should delegate to their parents the hashing and equality-checking for the properties that their parent types own, and simplify down to the properties that the child type owns.

For example, Event does its own thing, even though there is a type hierarchy above it that it completely ignores. It should probably use the type hierarchy instead. This way, bugfixes and feature enhancements will propagate to the other child types as well.

This may require spending some time understanding the relationship between UniqueComponent and RecurringComponent, and moving some of the hashing and equality logic to other places.

@rianjs
Copy link
Collaborator Author

rianjs commented May 24, 2018

C.f. #393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant