Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for additional iOS build configurations #769

Closed
dalewking opened this issue Sep 10, 2024 · 2 comments · Fixed by #765
Closed

Fix support for additional iOS build configurations #769

dalewking opened this issue Sep 10, 2024 · 2 comments · Fixed by #765
Labels
bug Something isn't working
Milestone

Comments

@dalewking
Copy link

So we added an additional configuration to the iOS side, but it was not working with task to copy framework resources to the app and the app crashed because the resources were not in the app.

To support iOS configurations other than DEBUG and RELEASE the cocoapods plugin provides the xcodeConfigurationToNativeBuildType property so you can map configurations to DEBUG and RELEASE.

Moko resources copy resources task is honoring this mapping so if the mapping is setup it will honor it.

The issue however is that the copy task is configured as soon as the moko resources plugin is applied which is before the xcodeConfigurationToNativeBuildType is setup.

The workaround that I had to use is to not apply the plugin in the plugins block:

plugins {
    kotlin("native.cocoapods")
    alias(libs.plugins.moko.resources) apply false
   ...
}

and then apply it later in the file after we configure the mapping.

The request is to delay the setup of the task so that the xcodeConfigurationToNativeBuildType mapping can be confgured without the workaround

@Alex009
Copy link
Member

Alex009 commented Sep 10, 2024

hi. thanks for report. it's same issue as here - #762
also in #762 i describe another workaround too.

we will fix it

@Alex009 Alex009 added this to the 0.24.3 milestone Sep 10, 2024
@Alex009 Alex009 added the bug Something isn't working label Sep 10, 2024
@Alex009 Alex009 mentioned this issue Sep 22, 2024
@Alex009
Copy link
Member

Alex009 commented Sep 22, 2024

will be available in 0.24.3 release

@Alex009 Alex009 closed this as completed Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants