Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dependencies defined for Composer are to tight #1

Open
skqr opened this issue Nov 7, 2014 · 8 comments
Open

The dependencies defined for Composer are to tight #1

skqr opened this issue Nov 7, 2014 · 8 comments

Comments

@skqr
Copy link

skqr commented Nov 7, 2014

Do you think we could review the versions in the composer.json file? Ideally, the constraint would require a package version equal or higher than the given one. Composer supports this, so it should not be a problem. It's even better than using an asterisk on the minor version, for instance.

@mhlavac
Copy link
Contributor

mhlavac commented Nov 7, 2014

@skqr 👍

@skqr
Copy link
Author

skqr commented Nov 10, 2014

Thanks, @mhlavac! New deps def looks awesome.

@mhlavac
Copy link
Contributor

mhlavac commented Nov 10, 2014

@skqr thank you, but we still have to fix the error for php 5.5 and php 5.6

@skqr
Copy link
Author

skqr commented Nov 10, 2014

Gotcha. Also, just realized I need the 2.4 version of Doctrine, so I'm still not able to use it 🔥

@mhlavac
Copy link
Contributor

mhlavac commented Nov 10, 2014

~2.3 means that any version higher or equal 2.3 but lower than 3.0 is supported. So it should not be any problem for you.

But tests have to be fixed first and I am not sure when I get to it.

@skqr
Copy link
Author

skqr commented Nov 10, 2014

Hah, sorry, you're absolutely right - I'm having this issue with two packages; this one, and the https:/alecsammon/php-raml-parser as well.

I'm guessing some dependency on the other package might be resulting in the installation of the 2.3 version, but it is getting installed instead of the 2.4.

I'm getting the 2.4 on my fork, which has * for all versions.

@icomefromthenet
Copy link
Owner

Thanks for the suggestions, I'll have a look tonight. I haven’t used this
in few months and dependencies have probably become stale.

On 11 November 2014 08:02, Javier Lorenzana [email protected]
wrote:

Hah, sorry, you're absolutely right - I'm having this issue with two
packages; this one, and the https:/alecsammon/php-raml-parser
as well.

I'm guessing some dependency on the other package might be resulting in
the installation of the 2.3 version, but it is getting installed instead of
the 2.4.

I'm getting the 2.4 on my fork, which has * for all versions.


Reply to this email directly or view it on GitHub
#1 (comment)
.

Regards
Lewis Dyer

@skqr
Copy link
Author

skqr commented Nov 11, 2014

No prob! Thank you for making it =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants