Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pico on OpenXR #721

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mikeskydev
Copy link
Member

Adds Android input mappings for Pico devices to OpenXR using their official plugin, mirrored to Icosa's mirror repo.
Need to test against other platforms.

@mikeskydev mikeskydev added the enhancement Feature added label May 24, 2024
@mikeskydev mikeskydev marked this pull request as ready for review May 24, 2024 13:00
Copy link
Member

@mikeage mikeage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the Pico builds failed; are any changes needed to build.yml?

Assets/Scripts/VrSdk.cs Show resolved Hide resolved
Assets/Scripts/VrSdk.cs Show resolved Hide resolved
Packages/manifest.json Show resolved Hide resolved
Assets/Scripts/VrSdk.cs Show resolved Hide resolved
@mikeage
Copy link
Member

mikeage commented May 26, 2024

If I'm not mistaken, the clash is not between Oculus and Pico, but rather Pico-from-git and Pico-from-zip

@mikeskydev
Copy link
Member Author

Correct, but both a result of pico copying oculus' meta files, and then additionally using the meta files/code in both of their packages, a big no no 😂

@mikeage
Copy link
Member

mikeage commented May 26, 2024

But didn't you fix that in the both the git mirror and in our build script? I don't think the problematic Common.cs.meta file is actually found anywhere, is it?

Actually, looking more carefully at the logs, isn't it because of this:

Library/PackageCache/com.unity.xr.openxr.picoxr@0c6e35dbf6/Platform/Editor/PicoGs.cs(37,55): error CS1061: 'PXR_PlatformSetting' does not contain a definition for 'useHighlight' and no accessible extension method 'useHighlight' accepting a first argument of type 'PXR_PlatformSetting' could be found (are you missing a using directive or an assembly reference?)
Library/PackageCache/com.unity.xr.openxr.picoxr@0c6e35dbf6/Platform/Editor/PicoGs.cs(40,46): error CS1061: 'PXR_PlatformSetting' does not contain a definition for 'useHighlight' and no accessible extension method 'useHighlight' accepting a first argument of type 'PXR_PlatformSetting' could be found (are you missing a using directive or an assembly reference?)

@mikeskydev mikeskydev marked this pull request as draft June 17, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants