-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Multiplayer UI #774
Draft
andybak
wants to merge
52
commits into
main
Choose a base branch
from
multiplayer/ui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Basic Multiplayer UI #774
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
dd1f515
WIP UI
mikeskydev a0ad425
Fix panel spawn
mikeskydev 774196c
Add MP panel to list
mikeskydev ed48bef
Oculus connection logic for testing
mikeskydev 52c54ff
Join logic
mikeskydev a23f473
WIP panel
mikeskydev 5d45586
Setup new button type, fix close button
mikeskydev 99b54d1
Change instantiation point of photon runner
mikeskydev 87c9a62
beta tag prefab
mikeskydev 3ee080a
Add alpha tag to multiplayer
mikeskydev 2fbf009
Merge remote-tracking branch 'origin/main' into multiplayer/ui
andybak 3882616
Remove duplicate "using" block
andybak 33efddc
Merge branch 'main' into multiplayer/ui
mikeskydev 2e03443
Merge remote-tracking branch 'origin/main' into multiplayer/ui
andybak e90d5dc
Merge branch 'main' into multiplayer/ui
mikeskydev b4cc4ec
Merge remote-tracking branch 'origin/main' into multiplayer/ui
andybak de5499a
Trigger CI workflow
sbanca 4fe8071
Minimal UI Implementation for multiplayer room
sbanca defb047
Merge remote-tracking branch 'origin/main' into multiplayer/ui
andybak ad8281b
Merge branch 'multiplayer/ui' of https:/icosa-foundation/…
andybak cf83975
Numeric keyboard popup for multiplayer room
andybak 16d3746
Buttons were too close to panel
andybak 1637dc9
Don't init XR manager on start
andybak ba14137
OpenXR should be the default in the editor
andybak ada058c
Admin panel label tweaks
andybak 7a2b832
Initialize keyboard with room name and refactor room name handling
sbanca 02dbcfe
Does Room exist
sbanca af158cc
Update MultiplayerManager.cs
sbanca af7a389
Merge remote-tracking branch 'origin/main' into multiplayer/ui
andybak 50e7266
Merge branch 'multiplayer/ui' of https:/icosa-foundation/…
andybak 3e3bc6f
Remove graphview reference
andybak 562b5bd
dotnet format
andybak a8e177b
Add Disconnection Handling for Multiplayer Mode Update
sbanca 438a276
Add Leave Room button
sbanca f2d2108
Update PhotonPlayerRig.prefab
sbanca b9fcd27
Update MultiplayerPanel.prefab
sbanca fc4d431
Editor UI to test connection to the room
sbanca 3213254
Reducing payload per Stroke Chunk
sbanca 0c07316
update Build GitHub Actions workflow (build.yml) to use the new photo…
sbanca eed2b6a
Update PopUpWindow_NumericKeyboard.prefab
sbanca 0bb5dfe
Include Photon Fusion project-specific assets in version control
sbanca ba5a48d
Include NetworkPrefabAssetCollection.asset in version control
sbanca 29ce9ff
Update PhotonPlayerRig.prefab
sbanca f45546b
removing the NetworkPrefbAssetCollection
sbanca 20e4a8b
Track PhotonAppSettings
sbanca 2543d85
Rebake PhotonPlayerRig
sbanca 69f666b
Update SketchControlsScript.cs
sbanca 6f13bb7
Update MultiplayerPanel.cs
sbanca ee77722
Handle the removal of the player rig when leaving the room
sbanca 8a589a0
Update PhotonManager.cs
sbanca e7843f2
Update SketchControlsScript.cs
sbanca e5de53b
Create NetworkPrefabAssetCollection.asset
sbanca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
// MultiplayerManagerInspector.cs | ||
using UnityEditor; | ||
using UnityEngine; | ||
using OpenBrush.Multiplayer; | ||
using System.Threading.Tasks; | ||
|
||
#if UNITY_EDITOR | ||
[CustomEditor(typeof(MultiplayerManager))] | ||
public class MultiplayerManagerInspector : Editor | ||
{ | ||
private MultiplayerManager multiplayerManager; | ||
private string roomName = "1234"; | ||
private bool isPrivate = false; | ||
private int maxPlayers = 4; | ||
private bool voiceDisabled = false; | ||
|
||
public override void OnInspectorGUI() | ||
{ | ||
// Get the target object (MultiplayerManager) | ||
multiplayerManager = (MultiplayerManager)target; | ||
|
||
GUILayout.Label("Multiplayer Manager Controls", EditorStyles.boldLabel); | ||
|
||
// Room data input fields | ||
roomName = EditorGUILayout.TextField("Room Name", roomName); | ||
|
||
|
||
if (GUILayout.Button("Connect to Room")) | ||
{ | ||
ConnectToRoom(); | ||
} | ||
|
||
// Draw default inspector below | ||
DrawDefaultInspector(); | ||
} | ||
|
||
private async void ConnectToRoom() | ||
{ | ||
if (multiplayerManager != null) | ||
{ | ||
RoomCreateData roomData = new RoomCreateData | ||
{ | ||
roomName = roomName, | ||
@private = isPrivate, | ||
maxPlayers = maxPlayers, | ||
voiceDisabled = voiceDisabled | ||
}; | ||
|
||
bool success = await multiplayerManager.Connect(roomData); | ||
if (success) | ||
{ | ||
Debug.Log($"Successfully connected to room: {roomName}"); | ||
} | ||
else | ||
{ | ||
Debug.LogError($"Failed to connect to room: {roomName}"); | ||
} | ||
} | ||
} | ||
} | ||
#endif |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
Assets/Photon/Fusion/Resources/NetworkProjectConfig.fusion.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
%YAML 1.1 | ||
%TAG !u! tag:unity3d.com,2011: | ||
--- !u!114 &11400000 | ||
MonoBehaviour: | ||
m_ObjectHideFlags: 0 | ||
m_CorrespondingSourceObject: {fileID: 0} | ||
m_PrefabInstance: {fileID: 0} | ||
m_PrefabAsset: {fileID: 0} | ||
m_GameObject: {fileID: 0} | ||
m_Enabled: 1 | ||
m_EditorHideFlags: 0 | ||
m_Script: {fileID: 1878438611, guid: 7de3b8b9e1263ad479e2d0c4261b7646, type: 3} | ||
m_Name: PhotonAppSettings | ||
m_EditorClassIdentifier: | ||
AppSettings: | ||
AppIdFusion: | ||
AppIdChat: | ||
AppIdVoice: | ||
AppVersion: | ||
UseNameServer: 1 | ||
FixedRegion: | ||
Server: | ||
Port: 0 | ||
ProxyServer: | ||
Protocol: 0 | ||
EnableProtocolFallback: 1 | ||
AuthMode: 0 | ||
EnableLobbyStatistics: 0 | ||
NetworkLogging: 1 |
154 changes: 154 additions & 0 deletions
154
Assets/Photon/Fusion/User/NetworkPrefabAssetCollection.asset
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,154 @@ | ||
%YAML 1.1 | ||
%TAG !u! tag:unity3d.com,2011: | ||
--- !u!114 &-7851828500534389341 | ||
MonoBehaviour: | ||
m_ObjectHideFlags: 0 | ||
m_CorrespondingSourceObject: {fileID: 0} | ||
m_PrefabInstance: {fileID: 0} | ||
m_PrefabAsset: {fileID: 0} | ||
m_GameObject: {fileID: 0} | ||
m_Enabled: 1 | ||
m_EditorHideFlags: 0 | ||
m_Script: {fileID: -571403812, guid: e725a070cec140c4caffb81624c8c787, type: 3} | ||
m_Name: NetworkedRig | ||
m_EditorClassIdentifier: | ||
AssetGuid: | ||
RawGuidValue: 7f1f582839553344c8827c8e7f15e4b2 | ||
--- !u!114 &-6679037723637155746 | ||
MonoBehaviour: | ||
m_ObjectHideFlags: 0 | ||
m_CorrespondingSourceObject: {fileID: 0} | ||
m_PrefabInstance: {fileID: 0} | ||
m_PrefabAsset: {fileID: 0} | ||
m_GameObject: {fileID: 0} | ||
m_Enabled: 1 | ||
m_EditorHideFlags: 0 | ||
m_Script: {fileID: -571403812, guid: e725a070cec140c4caffb81624c8c787, type: 3} | ||
m_Name: PhotonPlayerRig | ||
m_EditorClassIdentifier: | ||
AssetGuid: | ||
RawGuidValue: 9ee52735aebb6a445b4905c8aba8cfe3 | ||
--- !u!114 &-4876441823125888161 | ||
MonoBehaviour: | ||
m_ObjectHideFlags: 0 | ||
m_CorrespondingSourceObject: {fileID: 0} | ||
m_PrefabInstance: {fileID: 0} | ||
m_PrefabAsset: {fileID: 0} | ||
m_GameObject: {fileID: 0} | ||
m_Enabled: 1 | ||
m_EditorHideFlags: 0 | ||
m_Script: {fileID: -571403812, guid: e725a070cec140c4caffb81624c8c787, type: 3} | ||
m_Name: PlayerBallPrototype | ||
m_EditorClassIdentifier: | ||
AssetGuid: | ||
RawGuidValue: 6eca58070665ea64797a9b124cb6ab03 | ||
--- !u!114 &-3882056053279745226 | ||
MonoBehaviour: | ||
m_ObjectHideFlags: 0 | ||
m_CorrespondingSourceObject: {fileID: 0} | ||
m_PrefabInstance: {fileID: 0} | ||
m_PrefabAsset: {fileID: 0} | ||
m_GameObject: {fileID: 0} | ||
m_Enabled: 1 | ||
m_EditorHideFlags: 0 | ||
m_Script: {fileID: -571403812, guid: e725a070cec140c4caffb81624c8c787, type: 3} | ||
m_Name: FusionAvatar | ||
m_EditorClassIdentifier: | ||
AssetGuid: | ||
RawGuidValue: eedb965bcb4e568479a4828d17fbc1c3 | ||
--- !u!114 &-2813734544996678366 | ||
MonoBehaviour: | ||
m_ObjectHideFlags: 0 | ||
m_CorrespondingSourceObject: {fileID: 0} | ||
m_PrefabInstance: {fileID: 0} | ||
m_PrefabAsset: {fileID: 0} | ||
m_GameObject: {fileID: 0} | ||
m_Enabled: 1 | ||
m_EditorHideFlags: 0 | ||
m_Script: {fileID: 929548324, guid: e725a070cec140c4caffb81624c8c787, type: 3} | ||
m_Name: ~MISSING~PhotonPlayerRigBkp | ||
m_EditorClassIdentifier: | ||
AssetGuid: | ||
RawGuidValue: a5876108ffed6db47892c3ae59497b56 | ||
--- !u!114 &-2200370131318246874 | ||
MonoBehaviour: | ||
m_ObjectHideFlags: 0 | ||
m_CorrespondingSourceObject: {fileID: 0} | ||
m_PrefabInstance: {fileID: 0} | ||
m_PrefabAsset: {fileID: 0} | ||
m_GameObject: {fileID: 0} | ||
m_Enabled: 1 | ||
m_EditorHideFlags: 0 | ||
m_Script: {fileID: -571403812, guid: e725a070cec140c4caffb81624c8c787, type: 3} | ||
m_Name: BallPrototype | ||
m_EditorClassIdentifier: | ||
AssetGuid: | ||
RawGuidValue: 61b6ef4ffff3d8f4498968869591d6bf | ||
--- !u!114 &-272827184848844876 | ||
MonoBehaviour: | ||
m_ObjectHideFlags: 0 | ||
m_CorrespondingSourceObject: {fileID: 0} | ||
m_PrefabInstance: {fileID: 0} | ||
m_PrefabAsset: {fileID: 0} | ||
m_GameObject: {fileID: 0} | ||
m_Enabled: 1 | ||
m_EditorHideFlags: 0 | ||
m_Script: {fileID: -571403812, guid: e725a070cec140c4caffb81624c8c787, type: 3} | ||
m_Name: FusionColocationDriver | ||
m_EditorClassIdentifier: | ||
AssetGuid: | ||
RawGuidValue: 8ee45e6a80f151e48a85e55c1f12b1b1 | ||
--- !u!114 &11400000 | ||
MonoBehaviour: | ||
m_ObjectHideFlags: 0 | ||
m_CorrespondingSourceObject: {fileID: 0} | ||
m_PrefabInstance: {fileID: 0} | ||
m_PrefabAsset: {fileID: 0} | ||
m_GameObject: {fileID: 0} | ||
m_Enabled: 1 | ||
m_EditorHideFlags: 0 | ||
m_Script: {fileID: -225830702, guid: e725a070cec140c4caffb81624c8c787, type: 3} | ||
m_Name: NetworkPrefabAssetCollection | ||
m_EditorClassIdentifier: | ||
--- !u!114 &1613190245493424334 | ||
MonoBehaviour: | ||
m_ObjectHideFlags: 0 | ||
m_CorrespondingSourceObject: {fileID: 0} | ||
m_PrefabInstance: {fileID: 0} | ||
m_PrefabAsset: {fileID: 0} | ||
m_GameObject: {fileID: 0} | ||
m_Enabled: 1 | ||
m_EditorHideFlags: 0 | ||
m_Script: {fileID: -571403812, guid: e725a070cec140c4caffb81624c8c787, type: 3} | ||
m_Name: PlayerPrototype | ||
m_EditorClassIdentifier: | ||
AssetGuid: | ||
RawGuidValue: e4df49d0bf125a740a2c14ab6e887572 | ||
--- !u!114 &3549518608579063576 | ||
MonoBehaviour: | ||
m_ObjectHideFlags: 0 | ||
m_CorrespondingSourceObject: {fileID: 0} | ||
m_PrefabInstance: {fileID: 0} | ||
m_PrefabAsset: {fileID: 0} | ||
m_GameObject: {fileID: 0} | ||
m_Enabled: 1 | ||
m_EditorHideFlags: 0 | ||
m_Script: {fileID: -571403812, guid: e725a070cec140c4caffb81624c8c787, type: 3} | ||
m_Name: PlayerTransformPrototype | ||
m_EditorClassIdentifier: | ||
AssetGuid: | ||
RawGuidValue: 3251faa3ac8a66642bf6f9e8433499da | ||
--- !u!114 &4563594632895129475 | ||
MonoBehaviour: | ||
m_ObjectHideFlags: 0 | ||
m_CorrespondingSourceObject: {fileID: 0} | ||
m_PrefabInstance: {fileID: 0} | ||
m_PrefabAsset: {fileID: 0} | ||
m_GameObject: {fileID: 0} | ||
m_Enabled: 1 | ||
m_EditorHideFlags: 0 | ||
m_Script: {fileID: -571403812, guid: e725a070cec140c4caffb81624c8c787, type: 3} | ||
m_Name: PlayerRB2DPrototype | ||
m_EditorClassIdentifier: | ||
AssetGuid: | ||
RawGuidValue: dbc9b57ea26fbf84b8cc14b0882fe89b |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, it will take the latest. We probably should pin it, though, so this is a good change.