Penalty time in RELTIME #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
previously approved these changes
Jun 26, 2023
eldering
reviewed
Jun 26, 2023
There was a problem hiding this comment.
I think the score.total_time property in the scoreboard row objects should also be changed to RELTIME.
And while we're at it, I think we should also change the time property in the problem sub-objects in scoreboard rows from integer to RELTIME.
I think then we've removed all explicit references to time in minutes.
|
Added another commit to update scoreboard times to RELTIME as well. |
|
Yup, missed that. Fixed now. |
nickygerritsen
previously approved these changes
Jul 10, 2023
eldering
previously approved these changes
Jul 17, 2023
Contest penalty_time is the only time that's in integer minutes, and one of only 3 places where we even say minutes in the spec. As per issue icpc#150, it also blocks non-integer penalty times. This changes it to use RELTIME, which improves both issues. It does not attempt to address anything else in issue 150, namely no attempt to add additional scoring algorithms.
As per discussion on today's clics call, updating the scoreboard score times to RELTIME as well.
nickygerritsen
approved these changes
Jul 24, 2023
niemela
approved these changes
Jul 24, 2023
eldering
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contest penalty_time is the only time that's in integer minutes, and one of only 3 places where we even say minutes in the spec. As per issue #150, it also blocks non-integer penalty times.
This changes it to use RELTIME, which improves both issues. It does not attempt to address anything else in issue 150, namely no attempt to add additional scoring algorithms.