Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syntax highlighting and fixed opaque text marking #129

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

DamianSuess
Copy link

@DamianSuess DamianSuess commented Feb 2, 2023

Feature includes:

  • Added EditorConfig file to ensure Visual Studio settings match the project's unique preferences
  • Updated syntax highlighting rules to match those in the latest ILSpy
  • Added ILAsm-Mode-Dark.xshd style definition
  • Added display setting, Highlight Current Line

@DamianSuess
Copy link
Author

ha! silly me, just noticed the other ILSpy repo had an editorconfig. Replaced my implementation w/ the one you're using ;)

@DamianSuess
Copy link
Author

DamianSuess commented Feb 2, 2023

Please let me know if there is anything else needed. Overall, I'd like to see a ThemeManager for the resource dictionaries so that the Dark/Light themes can be properly managed, thus unifying the projects a bit better. I figured that was a bit out of scope here without asking permission first.

@DamianSuess
Copy link
Author

The latest check-in addresses an existing issue where the TextMarker's background box hides the selected text. The box is being drawn in TextMarkerService.Draw(..) on Line 118.

As a short workaround, I provided a semi-transparent color. Considering that the same code is being used for the WPF TextMarkerService and even the sample project, I'm guessing this may be an issue w/ AvaloniaEdit?

@DamianSuess DamianSuess changed the title Update syntax highlighting Update syntax highlighting and fixed opaque text marking Feb 3, 2023
@DamianSuess
Copy link
Author

DamianSuess commented Feb 3, 2023

Lastly, here is a sample screenshot of the improved text selection and text marking

Before:

SelectionAndTextMarking--Before

After:

SelectionAndTextMarking

@DamianSuess
Copy link
Author

Any thoughts on this PR?
Let me know of any suggested changes

DamianSuess added a commit to DamianSuess/AvaloniaILSpy that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant