Set the handles used for --client to use UTF-8 #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously they were binary-mode, so they used char8 “encoding”, taking codepoint values modulo 256, leading to cryptic identifier mangling errors when using idris-vim.
| @@ -151,6 +151,7 @@ startServer orig fn_in = do tid <- runIO $ forkOS serverLoop | |||
|
|
|||
| loop fn ist sock | |||
| = do (h,_,_) <- accept sock | |||
| hSetEncoding h utf8 | |||
| cmd <- hGetLine h | |||
There was a problem hiding this comment.
I was going through and replacing readFiles, writeFiles, hGetLines, and hPutStrLn with versions from System.IO.UTF8
for #94.
Would you think these lines should also get similiar treatment, or the hSetEncoding calls, or both?
Speaking of things to cat set on a handle - I was wondering if LineBuffering mode should be set, or what the default is?
LeifW
added a commit
to LeifW/Idris-dev
that referenced
this pull request
Jul 1, 2014
Replaced all usages of readFile, writeFile, hGetLine, and hPutStrLn from Prelude with versions from [System.IO.UTF8](http://hackage.haskell.org/package/utf8-string-0.3.8/docs/System-IO-UTF8.html) Fixes idris-lang#94 Tested with `export LANG=C`. Was able to load a unicode-containing .idr file, compile and run it, use interactive vim stuff like case-splitting and proof search, and could also :addproof from the repl. Technically, only the change to readFile in Idris/Chaser.hs is necessary to fix idris-lang#94. The rest are mainly for consistency. I am a little leary of changing the output encoding to unicode when the system encoding might not be that on the things that don't deal with idris code, e.g. the .c, .java, .pom, etc output files, that are then run through gcc, javac, whatever. Also, this might address the issue fixed by idris-lang#1334, and make idris-lang#1334 redunant?
edwinb
added a commit
that referenced
this pull request
Jul 1, 2014
Set the handles used for --client to use UTF-8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously they were binary-mode, so they used
char8“encoding”, takingcodepoint values modulo 256, leading to cryptic identifier mangling errors
when using idris-vim.