Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose important library versions #7713

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kesara
Copy link
Member

@kesara kesara commented Jul 20, 2024

Update /api/version to include

"other": {
    "xml2rfc": "<version>",
    "weasyprint": "<version>"
},

Fixes #3415

Update `/api/version` to include

```
"other": {
    "xml2rfc": "<version>",
    "weasyprint": "<version>"
},
```

Fixes ietf-tools#3415
@kesara
Copy link
Member Author

kesara commented Jul 20, 2024

@rjsparks is this implementation going in the correct direction?

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 88.76%. Comparing base (b00dfd3) to head (bc27442).
Report is 3 commits behind head on main.

Files Patch % Lines
ietf/__init__.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7713      +/-   ##
==========================================
- Coverage   88.79%   88.76%   -0.03%     
==========================================
  Files         296      296              
  Lines       41319    41330      +11     
==========================================
  Hits        36688    36688              
- Misses       4631     4642      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks
Copy link
Member

Yes - these seems reasonable.

@rjsparks
Copy link
Member

rjsparks commented Sep 4, 2024

@kesara - do you want to continue to pursue this?

@kesara
Copy link
Member Author

kesara commented Sep 4, 2024

@kesara - do you want to continue to pursue this?

Yes. I will. Sorry, I missed your reply during meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose versions of important underlying libraries
2 participants