Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Styling for blockquotes #402

Merged
merged 3 commits into from
May 7, 2024

Conversation

mgax
Copy link
Contributor

@mgax mgax commented Apr 3, 2024

Fix #321.

Here is what the blockquotes look like with this patch:

Screenshot 2024-04-03 at 15 37 06

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.72%. Comparing base (4ad3143) to head (b2e7e64).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   82.72%   82.72%           
=======================================
  Files         124      124           
  Lines        2599     2599           
=======================================
  Hits         2150     2150           
  Misses        449      449           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@SharmaineLim SharmaineLim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just need to tweak the text colour for accessibility.

I would suggest replacing the colour instead of relying on opacity. Maybe #666666 and #bebebe which are already in use elsewhere.

@mgax
Copy link
Contributor Author

mgax commented Apr 4, 2024

Looking good, just need to tweak the text colour for accessibility.

Good point, and thanks for the resource! The text colour is more similar to the body text, but it's slightly heavier, and there's the indentation bar, so I don't think that will be a problem.

Screenshot 2024-04-04 at 13 30 34

@kesara kesara changed the base branch from main to feat/modern-footer April 23, 2024 21:00
@kesara kesara merged commit 1b73a1f into ietf-tools:feat/modern-footer May 7, 2024
1 check passed
@mgax mgax deleted the feat/blockquote-styling branch May 8, 2024 07:07
@kesara kesara mentioned this pull request May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blockquotes in Wagtail are not properly styled
4 participants