Vendor BearSSL sources (same commit as the submodule) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikskuh
approved these changes
Aug 23, 2023
|
Trusting you on this |
it is resolved: ziglang/zig#17277 |
|
damn, the upstream bearssl.org server only supports tlsv1.[012] and zig fetch only tlsv1.3. |
|
i have to say i prefer submodules over vendored deps, with submodules you don't have to actually get the original upstream and compare it with the vendored one for any deviations - be them innocent or malicious. vendored libs thus create much more effort for the conscious user... |
|
i just did a diff between the vendored version and upstream #HEAD. the diff is substantial: https://ctrlc.hu/~stef/diff-vendored-upstream.patch |
|
see also #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows other packages to depend on zig-bearssl using zig's pm. It will be possible to remove vendored sources once ziglang/zig#14298 gets resolved