Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: 1225 horizontal lines not rendering at max and min #1266

Conversation

JoshMart
Copy link
Contributor

This fixes #1255 where extra horizontal lines would not be painted when they were to be drawn horizontally along the min or max of the chart.

@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Merging #1266 (f09d739) into master (122c6e3) will increase coverage by 0.02%.
The diff coverage is 38.29%.

@@            Coverage Diff             @@
##           master    #1266      +/-   ##
==========================================
+ Coverage   85.94%   85.97%   +0.02%     
==========================================
  Files          45       45              
  Lines        2945     2951       +6     
==========================================
+ Hits         2531     2537       +6     
  Misses        414      414              
Impacted Files Coverage Δ
.../src/chart/base/axis_chart/axis_chart_painter.dart 71.98% <38.29%> (+0.83%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imaNNeo
Copy link
Owner

imaNNeo commented Feb 19, 2023

We have this logic in BarChart too. Please check and fix it if there is any bug in the BarChart.
Thanks!

…or max

Update line/bar chart documentation with missing ExtraLinesData default
lines in the bounds of the view size and at x/y min/max
@JoshMart JoshMart force-pushed the 1225-horizontal-lines-not-rendering-at-max-and-min branch from 3cacf0e to 274d42a Compare March 5, 2023 01:46
CHANGELOG.md Outdated Show resolved Hide resolved
@imaNNeo
Copy link
Owner

imaNNeo commented Mar 6, 2023

BTW everything looks good to me.
Please fix the codecov issue, then we are ready to merge it.

Additional test for coverage
@JoshMart
Copy link
Contributor Author

JoshMart commented Mar 7, 2023

BTW everything looks good to me. Please fix the codecov issue, then we are ready to merge it.

codecov/patch is reporting uncovered lines on code that existed before this PR. The lines in question were simply indented because they are now wrapped in an if block. They are not new.

@imaNNeo imaNNeo enabled auto-merge (rebase) March 9, 2023 10:21
@imaNNeo imaNNeo disabled auto-merge March 9, 2023 10:21
@imaNNeo imaNNeo merged commit f0eddfa into imaNNeo:master Mar 9, 2023
@JoshMart JoshMart deleted the 1225-horizontal-lines-not-rendering-at-max-and-min branch March 1, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

top and bottom horizontalLines in ExtraLinesData not rendering since ^0.60.0
2 participants