-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A bunch of broken images, and escape hatches that "*fix*" them #257
Comments
Nice. Do you want to open this as a pull request or us to rebase changes incrementally? |
I'm fine with either approach. I didn't know if any of the changes I made are proper fixes. So this issue was just me sharing my experiments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello. I've been testing a bunch of images from random sources around the internet against some JPEG decoders, and found
a bunch that fail with
jpeg-decoder
.An image was considered potentially broken in my scripts if it failed with ffmpeg's
-err_detect explode
:The total number of potentially broken, but at least partially decode-able (by
djpeg
) images was 74, 27 of whichjpeg-decoder
already decoded without error, so theoretically, the decoder needs both a stricter and a more lenient modes of operation.
The remaining images all fail currently with
jpeg-decoder
, 27 of which should be safe to share and are attached below:broken_images.zip
I managed to "fix" all those images (including the non-sharable ones) with a few escape hatches, available in my fork here:
https:/MoSal/jpeg-decoder/commits/master
Those also "fix" images shared in issues around here like in #251 #229 and #228.
Details about the effects of each escape hatch on the broken images:
Note that the potentially redundant component-fall-back escape hatch fixes 3 images if the following escape hatch is not applied.
The text was updated successfully, but these errors were encountered: