update to swift 4.0

NetworkKit.xcodeproj/project.pbxproj

@@ -470,7 +470,7 @@
  isa = PBXProject;
  attributes = {
  LastSwiftUpdateCheck = 0730;
- LastUpgradeCheck = 0800;
+ LastUpgradeCheck = 0920;
  ORGANIZATIONNAME = alextelek;
  TargetAttributes = {
  2BB9D82C1C9AEF5400A9F47B = {
@@ -487,14 +487,14 @@
  };
  2BD3D3C91C92EE920080BC62 = {
  CreatedOnToolsVersion = 7.2.1;
- LastSwiftMigration = 0800;
+ LastSwiftMigration = 0920;
  };
  2BF2B6EF1CA44B7F0003939B = {
  CreatedOnToolsVersion = 7.3;
  };
  2BFCC4A21C91B8D500FD0CA9 = {
  CreatedOnToolsVersion = 7.2.1;
- LastSwiftMigration = 0800;
+ LastSwiftMigration = 0920;
  };
  2BFCC4B31C91C0B000FD0CA9 = {
  CreatedOnToolsVersion = 7.2.1;
@@ -978,7 +978,8 @@
  LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
  PRODUCT_BUNDLE_IDENTIFIER = com.alextelek.NetworkKitExample;
  PRODUCT_NAME = "$(TARGET_NAME)";
- SWIFT_VERSION = 3.0;
+ SWIFT_SWIFT3_OBJC_INFERENCE = On;
+ SWIFT_VERSION = 4.0;
  };
  name = Debug;
  };
@@ -995,7 +996,8 @@
  LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
  PRODUCT_BUNDLE_IDENTIFIER = com.alextelek.NetworkKitExample;
  PRODUCT_NAME = "$(TARGET_NAME)";
- SWIFT_VERSION = 3.0;
+ SWIFT_SWIFT3_OBJC_INFERENCE = On;
+ SWIFT_VERSION = 4.0;
  };
  name = Release;
  };
@@ -1040,14 +1042,20 @@
  CLANG_CXX_LIBRARY = "libc++";
  CLANG_ENABLE_MODULES = YES;
  CLANG_ENABLE_OBJC_ARC = YES;
+ CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
  CLANG_WARN_BOOL_CONVERSION = YES;
+ CLANG_WARN_COMMA = YES;
  CLANG_WARN_CONSTANT_CONVERSION = YES;
  CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
  CLANG_WARN_EMPTY_BODY = YES;
  CLANG_WARN_ENUM_CONVERSION = YES;
  CLANG_WARN_INFINITE_RECURSION = YES;
  CLANG_WARN_INT_CONVERSION = YES;
+ CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+ CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
  CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
+ CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+ CLANG_WARN_STRICT_PROTOTYPES = YES;
  CLANG_WARN_SUSPICIOUS_MOVE = YES;
  CLANG_WARN_UNREACHABLE_CODE = YES;
  CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -1090,14 +1098,20 @@
  CLANG_CXX_LIBRARY = "libc++";
  CLANG_ENABLE_MODULES = YES;
  CLANG_ENABLE_OBJC_ARC = YES;
+ CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
  CLANG_WARN_BOOL_CONVERSION = YES;
+ CLANG_WARN_COMMA = YES;
  CLANG_WARN_CONSTANT_CONVERSION = YES;
  CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
  CLANG_WARN_EMPTY_BODY = YES;
  CLANG_WARN_ENUM_CONVERSION = YES;
  CLANG_WARN_INFINITE_RECURSION = YES;
  CLANG_WARN_INT_CONVERSION = YES;
+ CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+ CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
  CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
+ CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+ CLANG_WARN_STRICT_PROTOTYPES = YES;
  CLANG_WARN_SUSPICIOUS_MOVE = YES;
  CLANG_WARN_UNREACHABLE_CODE = YES;
  CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -1146,7 +1160,8 @@
  PRODUCT_NAME = "$(TARGET_NAME)";
  SKIP_INSTALL = YES;
  SWIFT_OPTIMIZATION_LEVEL = "-Onone";
- SWIFT_VERSION = 3.0;
+ SWIFT_SWIFT3_OBJC_INFERENCE = On;
+ SWIFT_VERSION = 4.0;
  TVOS_DEPLOYMENT_TARGET = 9.0;
  WATCHOS_DEPLOYMENT_TARGET = 2.0;
  };
@@ -1171,7 +1186,8 @@
  PRODUCT_BUNDLE_IDENTIFIER = com.alextelek.NetworkKit;
  PRODUCT_NAME = "$(TARGET_NAME)";
  SKIP_INSTALL = YES;
- SWIFT_VERSION = 3.0;
+ SWIFT_SWIFT3_OBJC_INFERENCE = On;
+ SWIFT_VERSION = 4.0;
  TVOS_DEPLOYMENT_TARGET = 9.0;
  WATCHOS_DEPLOYMENT_TARGET = 2.0;
  };

NetworkKit.xcodeproj/xcshareddata/xcschemes/NetworkKit.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
- LastUpgradeVersion = "0800"
+ LastUpgradeVersion = "0920"
  version = "1.3">
  <BuildAction
  parallelizeBuildables = "YES"
@@ -40,6 +40,7 @@
  buildConfiguration = "Debug"
  selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
  selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+ language = ""
  shouldUseLaunchSchemeArgsEnv = "YES"
  codeCoverageEnabled = "YES">
  <Testables>
@@ -70,6 +71,7 @@
  buildConfiguration = "Debug"
  selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
  selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+ language = ""
  launchStyle = "0"
  useCustomWorkingDirectory = "NO"
  ignoresPersistentStateOnLaunch = "NO"

NetworkKit.xcodeproj/xcshareddata/xcschemes/NetworkKitExample.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
- LastUpgradeVersion = "0800"
+ LastUpgradeVersion = "0920"
  version = "1.3">
  <BuildAction
  parallelizeBuildables = "YES"
@@ -26,6 +26,7 @@
  buildConfiguration = "Debug"
  selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
  selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+ language = ""
  shouldUseLaunchSchemeArgsEnv = "YES">
  <Testables>
  <TestableReference
@@ -55,6 +56,7 @@
  buildConfiguration = "Debug"
  selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
  selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+ language = ""
  launchStyle = "0"
  useCustomWorkingDirectory = "NO"
  ignoresPersistentStateOnLaunch = "NO"

NetworkKit.xcodeproj/xcshareddata/xcschemes/NetworkKitMac.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
- LastUpgradeVersion = "0800"
+ LastUpgradeVersion = "0920"
  version = "1.3">
  <BuildAction
  parallelizeBuildables = "YES"
@@ -26,6 +26,7 @@
  buildConfiguration = "Debug"
  selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
  selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+ language = ""
  shouldUseLaunchSchemeArgsEnv = "YES"
  codeCoverageEnabled = "YES">
  <Testables>
@@ -56,6 +57,7 @@
  buildConfiguration = "Debug"
  selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
  selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+ language = ""
  launchStyle = "0"
  useCustomWorkingDirectory = "NO"
  ignoresPersistentStateOnLaunch = "NO"

NetworkKit.xcodeproj/xcshareddata/xcschemes/NetworkKitTvOS.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
- LastUpgradeVersion = "0800"
+ LastUpgradeVersion = "0920"
  version = "1.3">
  <BuildAction
  parallelizeBuildables = "YES"
@@ -26,6 +26,7 @@
  buildConfiguration = "Debug"
  selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
  selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+ language = ""
  shouldUseLaunchSchemeArgsEnv = "YES"
  codeCoverageEnabled = "YES">
  <Testables>
@@ -56,6 +57,7 @@
  buildConfiguration = "Debug"
  selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
  selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+ language = ""
  launchStyle = "0"
  useCustomWorkingDirectory = "NO"
  ignoresPersistentStateOnLaunch = "NO"

NetworkKit.xcodeproj/xcshareddata/xcschemes/NetworkKitWatchOS.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
- LastUpgradeVersion = "0800"
+ LastUpgradeVersion = "0920"
  version = "1.3">
  <BuildAction
  parallelizeBuildables = "YES"
@@ -26,6 +26,7 @@
  buildConfiguration = "Debug"
  selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
  selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+ language = ""
  shouldUseLaunchSchemeArgsEnv = "YES"
  codeCoverageEnabled = "YES">
  <Testables>
@@ -37,6 +38,7 @@
  buildConfiguration = "Debug"
  selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
  selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+ language = ""
  launchStyle = "0"
  useCustomWorkingDirectory = "NO"
  ignoresPersistentStateOnLaunch = "NO"

NetworkKit/Info.plist

@@ -19,7 +19,7 @@
  <key>CFBundleSignature</key>
  <string>????</string>
  <key>CFBundleVersion</key>
- <string>341</string>
+ <string>345</string>
  <key>NSPrincipalClass</key>
  <string></string>
 </dict>

NetworkKit/NKReachability.swift

@@ -50,13 +50,11 @@ class NKReachability: NSObject {
  }
 
  }) else {
-
  return false
  }
 
  var flags = SCNetworkReachabilityFlags()
  if !SCNetworkReachabilityGetFlags(defaultRouteReachability, &flags) {
-
  return false
  }
 

NetworkKit/NetworkKit.h

@@ -28,5 +28,3 @@
 
 FOUNDATION_EXPORT double NetworkKitVersionNumber;
 FOUNDATION_EXPORT const unsigned char NetworkKitVersionString[];
-
-

NetworkKitExample/AppDelegate.swift

@@ -31,33 +31,16 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
 
  var window: UIWindow?
 
-
  func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
- // Override point for customization after application launch.
- return true
- }
-
- func applicationWillResignActive(_ application: UIApplication) {
- // Sent when the application is about to move from active to inactive state. This can occur for certain types of temporary interruptions (such as an incoming phone call or SMS message) or when the user quits the application and it begins the transition to the background state.
- // Use this method to pause ongoing tasks, disable timers, and throttle down OpenGL ES frame rates. Games should use this method to pause the game.
- }
-
- func applicationDidEnterBackground(_ application: UIApplication) {
- // Use this method to release shared resources, save user data, invalidate timers, and store enough application state information to restore your application to its current state in case it is terminated later.
- // If your application supports background execution, this method is called instead of applicationWillTerminate: when the user quits.
- }
-
- func applicationWillEnterForeground(_ application: UIApplication) {
- // Called as part of the transition from the background to the inactive state; here you can undo many of the changes made on entering the background.
- }
 
- func applicationDidBecomeActive(_ application: UIApplication) {
- // Restart any tasks that were paused (or not yet started) while the application was inactive. If the application was previously in the background, optionally refresh the user interface.
- }
-
- func applicationWillTerminate(_ application: UIApplication) {
- // Called when the application is about to terminate. Save data if appropriate. See also applicationDidEnterBackground:.
+ return true
  }
+
+ func applicationWillResignActive(_ application: UIApplication) {}
+ func applicationDidEnterBackground(_ application: UIApplication) {}
+ func applicationWillEnterForeground(_ application: UIApplication) {}
+ func applicationDidBecomeActive(_ application: UIApplication) {}
+ func applicationWillTerminate(_ application: UIApplication) {}
 
 
 }

NetworkKitExample/NKEViewController.swift

@@ -31,7 +31,6 @@ class NKEViewController: UIViewController {
 
  override func viewDidLoad() {
  super.viewDidLoad()
- // Do any additional setup after loading the view, typically from a nib.
 
  _ = NKHTTPRequest.GET(
  "https://hacker-news.firebaseio.com/v0/item/11245652.json",
@@ -41,16 +40,11 @@ class NKEViewController: UIViewController {
  var item: NKEItem?
  let _ = item <-- data
 
- print(item)
+ print(item ?? "No item")
  },
  failure: { error in
  print(error.message)
  })
  }
-
- override func didReceiveMemoryWarning() {
- super.didReceiveMemoryWarning()
- // Dispose of any resources that can be recreated.
- }
 }