[minor] fix: recursive issue with Draft and JSONTypes #990
+48
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #839
I have added test under
__tests__/types/type-externals.ts
.There are several things I have observed:
yarn build -> 'cp' is not recognized as an internal or external command
I think these should be fixed.
Here is an video about the details: https://www.youtube.com/watch?v=PCRzWIubAEQ