Add DigestSet hex encoding validation #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasaky
reviewed
Mar 4, 2024
TomHennen
reviewed
Mar 4, 2024
marcelamelara
force-pushed
the
add-digest-set-validation
branch
from
8ddb77b
to
e8c06cf
Compare
Signed-off-by: Marcela Melara <[email protected]>
marcelamelara
force-pushed
the
add-digest-set-validation
branch
from
e8c06cf
to
7e1b9d7
Compare
Signed-off-by: Marcela Melara <[email protected]>
TomHennen
requested changes
Apr 4, 2024
… test case Signed-off-by: Marcela Melara <[email protected]>
TomHennen
reviewed
Apr 5, 2024
…ndable-output functions (shake), parameterize error outputs by algorithm/size Signed-off-by: Marcela Melara <[email protected]>
TomHennen
reviewed
Apr 8, 2024
TomHennen
reviewed
Apr 8, 2024
TomHennen
approved these changes
Apr 8, 2024
Signed-off-by: Marcela Melara <[email protected]>
adityasaky
approved these changes
Apr 8, 2024
TomHennen
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the spec requires digests in a DigestSet to be hex-encoded, this PR enhances the
Validate()function for the ResourceDescriptor and adds a corresponding test.