Skip to content
This repository has been archived by the owner on Aug 23, 2019. It is now read-only.

Use http.Client{Timeout: timeout} #2

Open
pyke369 opened this issue Oct 13, 2017 · 1 comment
Open

Use http.Client{Timeout: timeout} #2

pyke369 opened this issue Oct 13, 2017 · 1 comment
Labels

Comments

@pyke369
Copy link

pyke369 commented Oct 13, 2017

Hello,

I thing the whole code around Transport timeouts may be replaced by a simple http.Client{Timeout: timeout} statement.

Pierre-Yves

@inancgumus
Copy link
Owner

Hi, thx, With your recommendation, tests pass, however, I don't remember why I did it that way but when I was just giving it a timeout wasn't working on the production. Maybe, I should add a test to validate that production-level behavior.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants