-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Still maintained? (Update Dependencies?) #10
Comments
@nelsonic a PR would be welcome, but I'm not actively maintaining it. Would you like to be the new head maintainer? 😄 |
@indexzero I've added some basic tests on a branch: nelsonic#1 if(!module.parent) {
childrenOfPid(process.argv[2] || 1, function (err, data) {
console.log(data)
}) I tried to execute the file from inside my test: var child = cp.exec("node ./index.js", function(error, data) {
console.log('data: ' + data.length);
if (error !== null) {
console.log(red('exec error: ' + error));
}
}) But that still does not improve coverage... If you can live without 100% test coverage I can submit the PR. |
I would be happy to remove the |
Ok. I can do that.
|
@indexzero I have substituted: if(!module.parent) {
childrenOfPid(process.argv[2] || 1, function (err, data) {
console.log(data)
})
} for ./bin/ps-tree.js containing: #!/usr/bin/env node
'use strict';
require('../')(process.argv[2] || 1, function (err, data) {
console.log(data)
}); As a result we get 100% test coverage. 👍 |
Build passes: https://travis-ci.org/nelsonic/ps-tree/builds/56141651 |
@indexzero should I do a major _version bump_ in package.json or leave that to you? |
Hi @indexzero
is this module still maintained?
Do you have plans to update it?
e.g. dependencies:
Would you accept a PR with tests?
The text was updated successfully, but these errors were encountered: