Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Debian files packages files and minor updates to catch when PWM is zero. #971

Merged
merged 19 commits into from
Sep 11, 2024

Conversation

mcgillca
Copy link
Contributor

@mcgillca mcgillca commented Sep 8, 2024

Added Debian packages. Also, the UI would not pick up changes when the PWM was initially zero. Changed logic for this edge case.

Initial version of AStarBox as a 3rd-party driver.
New version detects if there is a problem or not with the I2C connection.

Also, changed the names to be consistent with Rodolphe's files. (AStarBox vs CAStarBox), and changed astarbox to indi-astarbox.
Update to improve format.
Again change format.
Formatting again
Another format change.
I hope I have this right now!
Getting name right in Readme
Called openAllPorts into connect so can use results to indicate whether connection successful  or not.

Moved getPortPWM for ports 5 and 6 into connect too - when in openAllPports m_bLinked was false at that point so no values collected.

Now called after m_bLlinked is true so that values are collected.
Merged Rodolphe's updates and mine.

m_bPortsOpen is tested before opening all ports, but getting PWM5 and 6 is now in connect.
Replaced 5 and 6 by their ENUMS instead for consistency.
Previously, setting PWM to zero turned the port off. However, this prevented the status from being read so that if changed elsewhere, it would not be picked up.

Now, the ports are left on though with power of zero (same as turned off from a physical perspective).

Also, tidied up the return codes from setPortPWMDutyCyclePercent since this returns an integer rather than a bool,
First pass debian package. Copied from indi-asi-power.
Changed to refer to indi-astarbox, rather than indi-air-power.
Updated channgelog - changed time from +100 to +0100 to put it in the correct format.
@knro knro merged commit dafbbdf into indilib:master Sep 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants