-
-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: inferno-compat 1.3.0-rc.2 breaks react-hot-loader #818
Comments
Hi @menberg thanks for letting us know about this issue. Are you using rc.2 or rc.1 rc.3 is not released? Also can you give minimal steps to reproduce please. |
Hi @Havunen, thanks for checking in. I've prepared a repository to reproduce the bug. It's found under https:/menberg/inferno-issue-818 Does this help to debug the issue? Thanks for letting me know and best regards. |
Thanks for creating the repo, I will have a look soon. |
It looks like "React" defined so that those properties are getters... I can't find anything from the source files related to this change. Maybe it has something to do with how we build stuff, ping @longlho |
kk will take a look |
issue is that /******/ // define getter function for harmony exports
/******/ __webpack_require__.d = function(exports, name, getter) {
/******/ if(!__webpack_require__.o(exports, name)) {
/******/ Object.defineProperty(exports, name, {
/******/ configurable: false,
/******/ enumerable: true,
/******/ get: getter
/******/ });
/******/ }
/******/ }; trying to figure out a fix |
I Dropped module entry point due to many issues it raises, this will be fixed in next RC. |
Observed Behaviour
I'm using react-hot-loader with inferno-compat, it worked until 1.2.2. With 1.3.0-rc.3 (correction: rc.2), I get an
Uncaught TypeError: Cannot set property createElement of #<Object> which has only a getter
on line
React.createElement = patchedCreateElement;
Expected Current Behaviour
inferno-compat 1.3.0 should work with react-hot-loader 3.0.0-beta.6 like before.
Inferno Metadata
macOS Sierra / Chrome / SSR enabled
The text was updated successfully, but these errors were encountered: