Skip to content

Commit

Permalink
Revert "Work around rust-lang#5134 for now"
Browse files Browse the repository at this point in the history
This reverts commit d46db71.
  • Loading branch information
infinity0 committed Mar 7, 2018
1 parent 1b1cae0 commit 23d42c8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 17 deletions.
10 changes: 3 additions & 7 deletions tests/testsuite/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4351,11 +4351,7 @@ fn avoid_dev_deps() {
.file("src/main.rs", "fn main() {}")
.build();

// --bins is needed because of #5134
assert_that(p.cargo("build").arg("--bins"),
execs().with_status(101));
assert_that(p.cargo("build").arg("--bins")
.masquerade_as_nightly_cargo()
.arg("-Zavoid-dev-deps"),
execs().with_status(0));
assert_that(p.cargo("build"), execs().with_status(101));
assert_that(p.cargo("build").masquerade_as_nightly_cargo()
.arg("-Zavoid-dev-deps"), execs().with_status(0));
}
14 changes: 4 additions & 10 deletions tests/testsuite/install.rs
Original file line number Diff line number Diff line change
Expand Up @@ -921,11 +921,8 @@ fn dev_dependencies_no_check() {
.file("src/main.rs", "fn main() {}")
.build();

// --bins is needed because of #5134
assert_that(p.cargo("build").arg("--bins"),
execs().with_status(101));
assert_that(p.cargo("install").arg("--bins"),
execs().with_status(0));
assert_that(p.cargo("build"), execs().with_status(101));
assert_that(p.cargo("install"), execs().with_status(0));
}

#[test]
Expand All @@ -951,12 +948,9 @@ fn dev_dependencies_lock_file_untouched() {
.file("a/src/lib.rs", "")
.build();

// --bins is needed because of #5134
assert_that(p.cargo("build").arg("--bins"),
execs().with_status(0));
assert_that(p.cargo("build"), execs().with_status(0));
let lock = p.read_lockfile();
assert_that(p.cargo("install").arg("--bins"),
execs().with_status(0));
assert_that(p.cargo("install"), execs().with_status(0));
let lock2 = p.read_lockfile();
assert!(lock == lock2, "different lockfiles");
}
Expand Down

0 comments on commit 23d42c8

Please sign in to comment.