-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Off By One Error in query/exector.go #19136
Labels
Comments
davidby-influx
added a commit
that referenced
this issue
Aug 21, 2021
executeQuery() iterates over statements until each is processed or if an error is encountered that causes the loop to exit pre-maturely. It should return ErrNotExecuted for each remaining statement in the query closes #19136
This was referenced Aug 21, 2021
4 tasks
davidby-influx
added a commit
that referenced
this issue
Aug 24, 2021
executeQuery() iterates over statements until each is processed or if an error is encountered that causes the loop to exit pre-maturely. It should return ErrNotExecuted for each remaining statement in the query closes #19136
davidby-influx
added a commit
that referenced
this issue
Aug 24, 2021
executeQuery() iterates over statements until each is processed or if an error is encountered that causes the loop to exit pre-maturely. It should return ErrNotExecuted for each remaining statement in the query closes #19136
4 tasks
chengshiwen
pushed a commit
to chengshiwen/influxdb
that referenced
this issue
Aug 11, 2024
executeQuery() iterates over statements until each is processed or if an error is encountered that causes the loop to exit pre-maturely. It should return ErrNotExecuted for each remaining statement in the query closes influxdata#19136
chengshiwen
pushed a commit
to chengshiwen/influxdb-cluster
that referenced
this issue
Aug 25, 2024
executeQuery() iterates over statements until each is processed or if an error is encountered that causes the loop to exit pre-maturely. It should return ErrNotExecuted for each remaining statement in the query closes influxdata/influxdb#19136
chengshiwen
pushed a commit
to chengshiwen/influxdb
that referenced
this issue
Aug 27, 2024
executeQuery() iterates over statements until each is processed or if an error is encountered that causes the loop to exit pre-maturely. It should return ErrNotExecuted for each remaining statement in the query closes influxdata#19136
chengshiwen
pushed a commit
to chengshiwen/influxdb-cluster
that referenced
this issue
Aug 28, 2024
executeQuery() iterates over statements until each is processed or if an error is encountered that causes the loop to exit pre-maturely. It should return ErrNotExecuted for each remaining statement in the query closes influxdata/influxdb#19136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
executeQuery()
iterates over statements until each is processed or if an error is encountered that causes the loop to exit pre-maturely.In that case (early exit) there is a loop that is meant send an appropriate response for any remaining statements (
ErrNotExecuted
).It looks like removing the
-1
from the condition part of the for loop would work buti
is sometimes set to the index of the previously successfully executed statement.I've tried a few ways of fixing this but I think this requires a little more thought to fix properly.
The impact of this bug is that remaining statements aren't properly handled.
The text was updated successfully, but these errors were encountered: