Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tsdb): Fix variables masked by a declaration in test #18129

Merged
merged 1 commit into from
May 18, 2020

Conversation

ayang64
Copy link
Contributor

@ayang64 ayang64 commented May 18, 2020

Before this commit, the to and from variables were being re-declared in a block in such a way that the values were not being used.

This patch uses regular assignment so that the values are visable outside of the block where they're set.

Closes #18128

Before this commit, the to and from variables were being re-declared in
a block in such a way that the values were not being used.

This patch uses regular assignment so that the values are visable
outside of the block where they're set.

Closes: 18128
@ayang64 ayang64 merged commit 4cbc6a4 into master-1.x May 18, 2020
ayang64 added a commit that referenced this pull request May 19, 2020
Before this commit, the to and from variables were being re-declared in
a block in such a way that the values were not being used.

This patch uses regular assignment so that the values are visable
outside of the block where they're set.

Closes: 18128
@jacobmarble jacobmarble deleted the fix-masked-variables-in-test branch January 2, 2024 22:44
chengshiwen pushed a commit to chengshiwen/influxdb that referenced this pull request Aug 11, 2024
Before this commit, the to and from variables were being re-declared in
a block in such a way that the values were not being used.

This patch uses regular assignment so that the values are visable
outside of the block where they're set.

Closes: 18128
chengshiwen pushed a commit to chengshiwen/influxdb that referenced this pull request Aug 27, 2024
Before this commit, the to and from variables were being re-declared in
a block in such a way that the values were not being used.

This patch uses regular assignment so that the values are visable
outside of the block where they're set.

Closes: 18128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants