fix: do not rename files on mmap failure #23396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If NewTSMReader() fails because mmap fails, do not rename the file, because the error is probably caused by vm.max_map_count being too low closes #23172
|
Looks like a good approach. Can we add a test for it somehow? Maybe dependency-inject a poisoned |
gwossum
reviewed
Jun 2, 2022
tsdb/engine/tsm1/file_store.go
Outdated
| if e := os.Rename(file.Name(), file.Name()+"."+BadTSMFileExtension); e != nil { | ||
| f.logger.Error("Cannot rename corrupt tsm file", zap.String("path", file.Name()), zap.Int("id", idx), zap.Error(e)) | ||
| readerC <- &res{r: df, err: fmt.Errorf("cannot rename corrupt file %s: %v", file.Name(), e)} | ||
| if e, ok := err.(MmapError); ok { |
There was a problem hiding this comment.
Should we be using errors.Is() here instead of a type assertion?
lesam
approved these changes
Jun 7, 2022
This was referenced Jun 7, 2022
davidby-influx
added a commit
that referenced
this pull request
Jun 9, 2022
davidby-influx
added a commit
that referenced
this pull request
Jun 10, 2022
chengshiwen
pushed a commit
to chengshiwen/influxdb
that referenced
this pull request
Aug 27, 2024
If NewTSMReader() fails because mmap fails, do not rename the file, because the error is probably caused by vm.max_map_count being too low closes influxdata#23172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If NewTSMReader() fails because mmap fails, do not
rename the file, because the error is probably
caused by vm.max_map_count being too low
closes #23172