fix: fully clean up partially opened TSI #23430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When one partition in a TSI fails to open, all previously opened partitions should be cleaned up, and remaining partitions should not be opened closes #23427
lesam
reviewed
Jun 10, 2022
lesam
reviewed
Jun 10, 2022
| f, err := os.Open(path) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| defer f.Close() | ||
| defer errors2.Capture(&err, f.Close)() |
lesam
reviewed
Jun 10, 2022
| if err := <-errC; err != nil { | ||
| return err | ||
| } | ||
| g := new(errgroup.Group) |
There was a problem hiding this comment.
I love the errgroup, we should do more of that - see also https://vorpus.org/blog/notes-on-structured-concurrency-or-go-statement-considered-harmful/
There was a problem hiding this comment.
I don't fully agree (edit: with the linked article) but it is nice to use the pattern where it fits.
lesam
reviewed
Jun 10, 2022
lesam
reviewed
Jun 10, 2022
tsdb/index/tsi1/index.go
Outdated
| @@ -277,33 +278,21 @@ func (i *Index) Open() error { | |||
| i.partitions[j] = p | |||
| } | |||
|
|
|||
| defer i.cleanUpFail(&rErr) | |||
There was a problem hiding this comment.
I think we want to defer this only after the Wait on errGroup - otherwise we could accidentally add a return and run cleanUpFail concurrently with the partition opening, which would be bad.
As I understand it, the partition type assumes Close is never called concurrently with Open.
lesam
approved these changes
Jun 10, 2022
davidby-influx
added a commit
that referenced
this pull request
Jun 13, 2022
davidby-influx
added a commit
that referenced
this pull request
Jun 13, 2022
davidby-influx
added a commit
that referenced
this pull request
Jun 14, 2022
davidby-influx
added a commit
that referenced
this pull request
Jun 14, 2022
chengshiwen
pushed a commit
to chengshiwen/influxdb
that referenced
this pull request
Aug 11, 2024
When one partition in a TSI fails to open, all previously opened partitions should be cleaned up, and remaining partitions should not be opened closes influxdata#23427
chengshiwen
pushed a commit
to chengshiwen/influxdb
that referenced
this pull request
Aug 27, 2024
When one partition in a TSI fails to open, all previously opened partitions should be cleaned up, and remaining partitions should not be opened closes influxdata#23427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one partition in a TSI fails to open,
all previously opened partitions should be cleaned up, and remaining partitions should not be opened
closes #23427