CreateShardGroup was not idempotent at the meta store level #6257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corylanou
force-pushed
the
meta-index-bug
branch
from
28eb12a
to
cb3d693
Compare
| @@ -770,17 +776,26 @@ func (c *Client) PrecreateShardGroups(from, to time.Time) error { | |||
|
|
|||
| // Create successive shard group. | |||
| nextShardGroupTime := g.EndTime.Add(1 * time.Nanosecond) | |||
| if newGroup, err := createShardGroup(data, di.Name, rp.Name, nextShardGroupTime); err != nil { | |||
| // if ti already exists, continue | |||
|
One minor typo and agree with @e-dard's comment but otherwise LGTM. |
| defer c.mu.RUnlock() | ||
| d := c.cacheData.Clone() | ||
| return *d | ||
| } |
There was a problem hiding this comment.
This name should just be Data() instead of GetData().
There was a problem hiding this comment.
fixed. My brain was stuck on that I had a SetData method right above it :-)
|
LGTM |
| @@ -52,6 +52,7 @@ This release removes all of the old clustering code. It operates as a standalone | |||
| - [#6178](https:/influxdata/influxdb/issues/6178): Ensure SHARD DURATION is checked when recreating a retention policy | |||
| - [#6223](https:/influxdata/influxdb/issues/6223): Failure to start/run on Windows. Thanks @mvadu | |||
| - [#6237](https:/influxdata/influxdb/issues/6237): Enable continuous integration testing on Windows platform via AppVeyor. Thanks @mvadu | |||
| - [#6257](https:/influxdata/influxdb/issues/6257): CreateShardGroup was incrementing meta data index even when it was idempotent. | |||
There was a problem hiding this comment.
0.12.0 has already been released. This should go into 0.13.0 and then be copied to 0.12.1 if it's going to be part of that release.
|
Minor nits, otherwise lgtm |
corylanou
force-pushed
the
meta-index-bug
branch
from
cb3d693
to
ba127a9
Compare
corylanou
force-pushed
the
meta-index-bug
branch
from
ba127a9
to
7eaf7f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was causing the index on the meta store to index for EVERY single write, and basically doubled the disk ops because of the fsync.