Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add librato output plugin, update datadog plugin #322

Closed
wants to merge 1 commit into from

Conversation

jipperinbham
Copy link
Contributor

The following PR serves 2 purposes:

  • add a new output plugin for sending metrics to Librato
  • update datadog output plugin to skip any metric where the value cannot be converted to a float64

Also added READMEs for each output.

@sparrc
Copy link
Contributor

sparrc commented Oct 26, 2015

looks great, thanks much @jipperinbham 👍

@sparrc sparrc closed this in 7d15061 Oct 26, 2015
)

type Librato struct {
ApiUser string
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go style tends to capitalize 3-letter acronyms. So this should be APIUser.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to know, I assume I'd need to annotate it with toml:"api_user" as well?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apiUser would be more inline with what we would do in core.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, my understanding was fields needed to be exported in order to be set properly from the toml config?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm talking about the JSON encoding tag names. They can be lower case.

So be clear, the core team would write:

type Librato struct {
    APIUser string `json:"apiUser"`
}

@otoolep
Copy link

otoolep commented Oct 26, 2015

Some style suggestions, which would be more inline with how we code in Core. Not a big deal however.

allenj pushed a commit to allenj/telegraf that referenced this pull request Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants