Docker host mount prefix #3529
Merged
Docker host mount prefix #3529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the behavior of "HOST_MOUNT_PREFIX" when listing out system partition sizes. Previously, HOST_MOUNT_PREFIX was appended to every partition found on the system. This meant that only partitions with matching mount points between docker container and the host would be successfully listed. This appears to be an issue with assumptions about how upstream ps would behave when listing partitions inside docker containers.
…ocker-host-mount-prefix
|
@m4ce @j-vizcaino @chadnickbok If you can review or test it would be appreciated. |
3 tasks
danielnelson
added a commit
that referenced
this pull request
Dec 1, 2017
(cherry picked from commit 7f66863)
2 tasks
aromeyer
pushed a commit
to aromeyer/telegraf
that referenced
this pull request
May 19, 2018
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2812, but only filters partitions if there is a conflict between the filesystem and the
HOST_MOUNT_PREFIX, i.e.:/mnt/foovs/hostfs/mnt/foo.closes #1544
closes #2811
closes #3483
Required for all PRs: