Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing perf counters fix #7060

Merged
merged 2 commits into from
Feb 21, 2020

Conversation

Trovalo
Copy link
Collaborator

@Trovalo Trovalo commented Feb 21, 2020

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Resolves #7059
Fixed some filter conditions in the Performance Counters queries (both v1 and v2).
The column "object_name" has different values between default and named instance

  • Default Instance - object_name = SQLServer:Batch Resp Statistics
  • Named Instance - object_name = :Batch Resp Statistics

The fix (in its own commit) has been made also for the v1 query (the logic is exactly the same), but I have no way to test it since none of my databases gathers the affected "object_name", which are "%FileTable" and"%Backup Device".

@danielnelson danielnelson added area/sqlserver fix pr to fix corresponding bug labels Feb 21, 2020
@danielnelson
Copy link
Contributor

@denzilribeiro Can you take a look?

Copy link
Contributor

@denzilribeiro denzilribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree - will allow capturing on named instances

@danielnelson danielnelson added this to the 1.13.4 milestone Feb 21, 2020
@danielnelson danielnelson merged commit 413ca89 into influxdata:master Feb 21, 2020
danielnelson pushed a commit that referenced this pull request Feb 21, 2020
@Trovalo Trovalo deleted the Missing-PerfCounters-Fix branch February 22, 2020 13:49
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sqlserver fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlServer Input - Missing "Batch Resp Statistics" for named instances
4 participants