Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output stats to the Instrumental TCP Collector #1139

Closed
wants to merge 1 commit into from
Closed

Output stats to the Instrumental TCP Collector #1139

wants to merge 1 commit into from

Conversation

jasonroelofs
Copy link
Contributor

This plugin adds support for the Instrumental stats gathering, graphing, and alerting service. It provides metrics very close to the Graphite formula with some small tweaks.

Documentation for Instrumental's collector here: https://instrumentalapp.com/docs/tcp-collector

outputs.Add("instrumental", func() telegraf.Output {
return &Instrumental{
Host: DefaultHost,
Template: graphite.DEFAULT_TEMPLATE,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure what the best way to provide default values is here. Does this get over-written by the Config parsing or does any already-set value take precedence?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will get overwritten by the config file parsing

@jasonroelofs
Copy link
Contributor Author

Improvements made.

@sparrc
Copy link
Contributor

sparrc commented May 3, 2016

@jasonroelofs sorry about that, we had a problem with our CI script, please rebase and try pushing again

@jasonroelofs
Copy link
Contributor Author

@sparrc All good. Rebased and green again.

case "histogram":
metricType = "increment"
case "set":
metricType = "gauge_absolute"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gauge_absolute is deprecated and is now just an alias for gauge, you should use gauge for set.

@jasonroelofs
Copy link
Contributor Author

@mediocretes Thanks for the feedback. I believe I've addressed these issues. I'm also now checking for stats with characters Instrumental will not accept to help protect against sending bad stats.

@mediocretes
Copy link
Contributor

Looks good. For name validation, you may find /^([\d\w\-_]+\.)*[\d\w\-_]+$/ useful, and I'll see about making that exact regex or a description of it more visible in the docs.

There's still a mention of gauge_absolute in the readme, too, I must have skipped over it last time I reviewed.

@sparrc sparrc closed this in f32916a May 18, 2016
@jasonroelofs jasonroelofs deleted the instrumental-output-plugin branch May 18, 2016 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants