Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(processors.aws_ec2): Remove leading slash and cancel worker only if it exists #15965

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Oct 2, 2024

Summary

Currently, tags added by the AWS EC2 processor with "metadata" contain a leading slash. This PR fixes this issue and avoids a panic when running Telegraf with --test.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15906

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/processor labels Oct 2, 2024
@srebhan srebhan mentioned this pull request Oct 2, 2024
@srebhan srebhan self-assigned this Oct 2, 2024
@srebhan srebhan added the area/aws AWS plugins including cloudwatch, ecs, kinesis label Oct 2, 2024
@kirillmandrygin
Copy link

@srebhan I can not download build artifacts, I get 404 error

# wget https://output.circle-artifacts.com/output/job/672f852a-4cf7-44a8-8122-ae6474904c18/artifacts/0/build/dist/telegraf-1.33.0~d8ff0c4c_linux_amd64.tar.gz
--2024-10-07 08:25:10--  https://output.circle-artifacts.com/output/job/672f852a-4cf7-44a8-8122-ae6474904c18/artifacts/0/build/dist/telegraf-1.33.0~d8ff0c4c_linux_amd64.tar.gz
Resolving output.circle-artifacts.com (output.circle-artifacts.com)... 3.162.140.128, 3.162.140.108, 3.162.140.86, ...
Connecting to output.circle-artifacts.com (output.circle-artifacts.com)|3.162.140.128|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2024-10-07 08:25:10 ERROR 404: Not Found.

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 7, 2024

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 7, 2024
@srebhan srebhan merged commit ba413e3 into influxdata:master Oct 7, 2024
26 of 27 checks passed
@srebhan srebhan deleted the aws_ec2_issue_15906 branch October 7, 2024 14:09
@github-actions github-actions bot added this to the v1.32.1 milestone Oct 7, 2024
srebhan added a commit that referenced this pull request Oct 7, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/aws AWS plugins including cloudwatch, ecs, kinesis fix pr to fix corresponding bug plugin/processor ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS EC2 issues
3 participants