Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
I've read #1460 and I understand that storing pid as a tag leads to performance problems. However, scenarios(such as ours) exist where having pid as a tag is desirable.
We have a number of long running processes, all with the same name. We're monitoring these processes with procstat. All of our data goes into influx under a 1 day retention policy and is downsampled and placed under a 1 week retention policy. Therefore at any point in time the number of unique pids we store is going to be relatively low.
Not having pid as a tag makes downsampling very difficult, if not impossible. Grouping by fields isn't allowed and therefore doing things like finding the max(memory_rss) / minute , which would require us to group by pid, isn't possible.
This has also had ripple effects making the data difficult to work with in Grafana as well.
Therefore, I've made it possible to have pid as a tag instead of a field via the configuration.