added linux/darwin min/max ping values to match windows plugin #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added linux/darwin min/max ping values to match windows plugin
hestonk
changed the title
hestonk
changed the title
|
can't figure out why circleci is complaining about the go format. When i run the command and go through the 2 files i've modified, nothing seems out-of go-lang code standards. Any advice? |
|
Sorry the error message is not great in our circleci script. Have you ran |
|
|
|
Thanks, it will be there. |
jeichorn
pushed a commit
to jeichorn/telegraf
that referenced
this pull request
Jul 24, 2017
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Linux ping pluging was missing values for min and max. Wanted to capture that data since we already have it in the ping output.
Required for all PRs: