Configurable metrics endpoint for prometheus output #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the metrics path configurable but /metrics by default. Using a non default value can be useful when used in k8s pods with multiple containers that have non standard prometheus metric paths. Some apps already use /metrics for something else.
|
Code is good, I'm just curious about one thing: since the output is on its own port, why do you need the path to be different? |
|
I need the path to be the same. The limitation I faced was that the main application we had running in some pods I was changing was exposing prometheus in a non standard path since |
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the metrics path configurable but /metrics by default. Using a non
default value can be useful when used in k8s pods with multiple containers
that have non standard prometheus metric paths.
Some apps already use /metrics for something else.
Required for all PRs: