Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use MAX() instead of SUM() for latency measurements #3471

Merged
merged 2 commits into from
Nov 17, 2017

Conversation

erayaslan
Copy link
Contributor

Using SUM() results in multi-second latency measurements when multiple files are used for a database - which is typical for tempdb. Using MAX() gives a more meaningful measurement. AVG() can be used as well but will hide problems when one of the db files encounters a problem. Example:

File0: 30ms
File1: 40ms
File2: 50ms
File3: 60ms
File4: 70ms
File5: 80ms
File6: 90ms

SUM (currently what is reported) results in 420 ms latency, MAX (current proposal) in 90ms and AVG in 60ms

Using SUM() results in multi-second latency measurements when multiple files are used for a database - which is typical for tempdb.  Using MAX() gives a more meaningful measurement.   AVG() can be used as well but will hide problems when one of the db files encounters a problem.  Example:

File0: 30ms
File1: 40ms
File2: 50ms
File3: 60ms
File4: 70ms
File5: 80ms
File6: 90ms

SUM (currently what is reported) results in 420 ms latency, MAX (current proposal) in 90ms and AVG in 60ms
use MAX() instead of SUM() for latency measurements
@danielnelson
Copy link
Contributor

@zensqlmonitor @m82labs Could you help review this change?

Copy link
Contributor

@m82labs m82labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that MAX would make more sense here. Or if it could be rewritten to include both MAX and AVG.

@danielnelson danielnelson added this to the 1.5.0 milestone Nov 17, 2017
@danielnelson danielnelson merged commit a06ee58 into influxdata:master Nov 17, 2017
aromeyer pushed a commit to aromeyer/telegraf that referenced this pull request May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants