Add Particle Webhook Plugin #3477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Webhook Plugin for the Partricle.io platform
| defer r.Body.Close() | ||
| e := newEvent() | ||
| if err := json.NewDecoder(r.Body).Decode(e); err != nil { | ||
| log.Println(err) |
There was a problem hiding this comment.
Use rb.acc.AddError( here, which will log the message with a message about which plugin generated it and increment the error counter for the internal plugin.
| pTime, err := e.Time() | ||
| if err != nil { | ||
| pTime = time.Now() | ||
| log.Printf("error parsing particle event time: %s. Using telegraf host time instead: %s", e.PublishedAt, pTime) |
There was a problem hiding this comment.
I would probably use AddError here too, unless you think it is better to not increment the gather error count.
There was a problem hiding this comment.
The error here can probably just be removed. It's not really an error, probably, so much as a "didn't work, but we can go on".
aromeyer
pushed a commit
to aromeyer/telegraf
that referenced
this pull request
May 19, 2018
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Webhook Plugin for the Partricle.io platform
Required for all PRs: