Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Graphite 1.1.x protocol #4165

Merged
merged 4 commits into from
May 21, 2018
Merged

Add support for Graphite 1.1.x protocol #4165

merged 4 commits into from
May 21, 2018

Conversation

R4scal
Copy link
Contributor

@R4scal R4scal commented May 18, 2018

Hi
This PR will add support for Graphite 1.1.x protocol (with tags support) http://graphite.readthedocs.io/en/latest/tags.html#graphite-tag-support

This is a concept that working for me. Any feedback is welcomed

@R4scal R4scal mentioned this pull request May 18, 2018
Closed
@danielnelson
Copy link
Contributor

Thanks for the PR, would it be possible for you to add the new functionality into the old graphite serializer and add an option graphite_tag_support? I think this will cut down on duplicate logic.

@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label May 19, 2018
@R4scal
Copy link
Contributor Author

R4scal commented May 19, 2018

@danielnelson Done. I was add graphite_tag_support option to original graphite oputput

@R4scal
Copy link
Contributor Author

R4scal commented May 21, 2018

name as tag name is reserved for graphite metric and will be replaced with _name in last commit, because graphite server silently drop this tag from metrics

@danielnelson danielnelson added this to the 1.7.0 milestone May 21, 2018
@danielnelson
Copy link
Contributor

closes #3830

@danielnelson danielnelson merged commit 7660315 into influxdata:master May 21, 2018
leodido pushed a commit that referenced this pull request May 22, 2018
@R4scal @leodido
Add support for Graphite 1.1.x tags (#4165)
09e809a
maxunt pushed a commit that referenced this pull request Jun 26, 2018
@R4scal @danielnelson
Add support for Graphite 1.1.x tags (#4165)
a0c0863
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
@R4scal @otherpirate
Add support for Graphite 1.1.x tags (influxdata#4165)
6d666d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@R4scal @danielnelson