Feature : size options can come with units (KB, MiB, ...) #4852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Some options can now be expressed either as int (without quotes, representing the value in Bytes), either as strings with units ("100KiB", "-5MB" ...). These options are :
I've not modified max_message_bytes from outputs/kafka because 1. the parallel option in kafka is also expressed in bytes without units and 2. it would be necessary to rename the option.
The default configuration is also updated to show examples with units.
How it works
It adds the internal.Size type, which can be used by plugins. The configuration option is processed by (*Size) UnmarshalTOML function, which uses units package.
Required for all PRs: