Plugins parsers csv unix timestamp #5047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glinton
approved these changes
Nov 28, 2018
There was a problem hiding this comment.
Thanks! While this works, I think it would be nice to eventually centralize the json time format logic into the internal package
danielnelson
suggested changes
Nov 28, 2018
There was a problem hiding this comment.
Thanks @tkanos, in order to be closer in behavior to the other parsers can you make it so that if the csv_timestamp_format = "unix" then the format is parsed as unix time.
If we try to use unix timestamp in the csv file, we will get an error. This commit fixes that. * if the csv_timestamp_format = "unix" we try to parse the timestamp assuming that we will get an epoch in ms. * Put all the parsing timestamp part in a function (as it deserves it :D)
tkanos
force-pushed
the
plugins-parsers-csv-unix-timestamp
branch
from
5007b2a
to
f2fdaae
Compare
|
Thanks @danielnelson for the advice. It was done. |
danielnelson
added
the
feat
danielnelson
approved these changes
Nov 29, 2018
| @@ -75,7 +75,8 @@ document. | |||
|
|
|||
| The `csv_timestamp_column` option specifies the column name containing the | |||
| time value and `csv_timestamp_format` must be set to a Go "reference time" | |||
| which is defined to be the specific time: `Mon Jan 2 15:04:05 MST 2006`. | |||
| which is defined to be the specific time: `Mon Jan 2 15:04:05 MST 2006`, | |||
| it can also be `unix` (for epoch in ms format like 1257894000 ) | |||
There was a problem hiding this comment.
Actually this for seconds, not ms, so worries I'll switch it post merge.
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Description.
For now the csv parser does not handle unix timestamp like
1257894000as csv_timestamp_format in the csv as timestamp.So to fix that if csv_timestamp_format = Unix, we assume that the timestamp is an epoch ms format.
I have also added unit tests, and no others unit test were broken.
=== RUN TestBasicCSV
--- PASS: TestBasicCSV (0.00s)
=== RUN TestHeaderConcatenationCSV
--- PASS: TestHeaderConcatenationCSV (0.00s)
=== RUN TestHeaderOverride
--- PASS: TestHeaderOverride (0.00s)
=== RUN TestTimestamp
--- PASS: TestTimestamp (0.00s)
=== RUN TestTimestampError
--- PASS: TestTimestampError (0.00s)
=== RUN TestTimestampUnixFormat
--- PASS: TestTimestampUnixFormat (0.00s)
=== RUN TestQuotedCharacter
--- PASS: TestQuotedCharacter (0.00s)
=== RUN TestDelimiter
--- PASS: TestDelimiter (0.00s)
=== RUN TestValueConversion
--- PASS: TestValueConversion (0.00s)
=== RUN TestSkipComment
--- PASS: TestSkipComment (0.00s)
=== RUN TestTrimSpace
--- PASS: TestTrimSpace (0.00s)
=== RUN TestSkipRows
--- PASS: TestSkipRows (0.00s)
=== RUN TestSkipColumns
--- PASS: TestSkipColumns (0.00s)
=== RUN TestSkipColumnsWithHeader
--- PASS: TestSkipColumnsWithHeader (0.00s)
=== RUN TestParseStream
--- PASS: TestParseStream (0.00s)
PASS
ok github.com/influxdata/telegraf/plugins/parsers/csv